This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix #533, make a zone-mix to handle like electron/nw to patch browser and nodejs#608
Merged
mhevery merged 1 commit intoangular:masterfrom Jan 23, 2017
Merged
Conversation
Closed
mhevery
reviewed
Jan 23, 2017
Contributor
mhevery
left a comment
mhevery
left a comment
There was a problem hiding this comment.
This looks good, but i am wondering about the mix name. Why not just electron?
| !isNode && !isWebWorker && !!(typeof window !== 'undefined' && window['HTMLElement']); | ||
|
|
||
| // we are in electron of nw, so we are both browser and nodejs | ||
| export const isMix: boolean = typeof process !== 'undefined' && |
Contributor
There was a problem hiding this comment.
Why do we call it mix? Would electron be a better name?
Collaborator
Author
There was a problem hiding this comment.
I just wonder if nw.js is the same with electron, if we only handle electron, zone-electron is a better name
Collaborator
Author
|
@mhevery , I think nw.js should have the same behavior with electron, so I use zone-mix and isMix name here, please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #533, in electron/nw.js, we may need to patch both browser API and nodejs API, so we need a zone-mix.js to contains both patched API.