This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix #593, only call removeAttribute when have the method#594
Merged
mhevery merged 1 commit intoangular:masterfrom Jan 17, 2017
Merged
fix #593, only call removeAttribute when have the method#594mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
|
Awesome! Just got bitten by this, rolling back to 0.6.x works until this patch gets released |
JiaLiPassion
force-pushed
the
issue-593
branch
from
2810188 to
7cc3e32
Compare
JiaLiPassion
force-pushed
the
issue-593
branch
from
7cc3e32 to
15eeca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #593, the issue can be described as following case.
When first time try to get xhr.onreadystatechange, it will access patched getter, and because
canPatchPropertyDescriptor change the getter which always return true, so the logic will go to
this.removeAttribute part which is not correct (this.removeAttribute is only for DOMElement).