Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix #577, canPatchViaPropertyDescriptor test break XHR prototype#578

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-577
Jan 12, 2017
Merged

fix #577, canPatchViaPropertyDescriptor test break XHR prototype#578
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-577

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

fix #577, canPatchViaPropertyDescriptor test should add configurable to XMLHttpRequest.prototype.onreadystatechange, otherwise in opera 12, by default
XMLHttpRequest.prototype.onreadystatechange,

so after test below.

Object.defineProperty(XMLHttpRequest.prototype, 'onreadystatechange', {
    get: function() {
      return true;
    }
});

XMLHttpRequest.prototype.onreadystatechange become non-configurable.

@mhevery mhevery merged commit c297752 into angular:master Jan 12, 2017
@JiaLiPassion JiaLiPassion deleted the issue-577 branch January 12, 2017 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot assign "onreadystatechange" for XMLHttpRequest in Opera 12 in strict mode

3 participants