This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix inline event handler issue #525 #540#541
Merged
mhevery merged 5 commits intoangular:masterfrom Dec 18, 2016
Merged
Conversation
Collaborator
Author
|
If zone.js don't want to support inline event handler attribute, this PR is not necessary, inline event handler is not a good solution anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #525 and #540, inline event handler will not be patched with zone. And when you want to get the inline event handler will return null.
The func will not be patched, and if you access document.getElementById('btn1').onclick will return null.
The PR will not totally fixed the issue, if you don't access the elem.onclick for example, still no patch(but not null, you will get the original native version handler). you should add the following code to patch if you want to handle inline event handler