fix(bundling): switch to using umd bundles#457
Conversation
|
note: I've included the updates from running Let me know if you'd like me to revert the changes to stuff in |
| @@ -1,3 +1,9 @@ | |||
| (function (global, factory) { | |||
There was a problem hiding this comment.
We should add copyright here:
/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
There was a problem hiding this comment.
Also while it is nice to see final product, do revert dist folder. before checking in.
There was a problem hiding this comment.
Added copyright.
ACK for reverting dist folder, will do before checking in.
| (factory()); | ||
| }(this, (function () { 'use strict'; | ||
|
|
||
| (function () { |
There was a problem hiding this comment.
All of the specs have their own closure which auto-detects global. We should remove these?
|
Responded to comments and updated the dist files - I'll squash and revert the dist files before merging if this looks good to you. |
This means that we will stop polluting the global namespace when zone.js is included. Fixes angular#456
3 participants
This means that we will stop polluting the global namespace when
zone.js is included.
Fixes #456