Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix: run all timers in passage of time in a single fakeAsync's tick call#454

Closed
kasiditi wants to merge 4 commits intoangular:masterfrom
kasiditi:fix-tick
Closed

fix: run all timers in passage of time in a single fakeAsync's tick call#454
kasiditi wants to merge 4 commits intoangular:masterfrom
kasiditi:fix-tick

Conversation

@kasiditi
Copy link
Copy Markdown
Contributor

@kasiditi kasiditi commented Sep 18, 2016

The tick() funtion should run a timer created during that passage of time if that timer is scheduled to run in that passage of time. I write it in a hurry. Any suggestion is welcome.

This fix #angular/angular#10299.

@googlebot
Copy link
Copy Markdown

googlebot commented Sep 18, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Sep 18, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kasiditi
Copy link
Copy Markdown
Contributor Author

kasiditi commented Sep 18, 2016

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Sep 18, 2016

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Sep 18, 2016

CLAs look good, thanks!

@mhevery mhevery closed this in c76255b Oct 1, 2016
mhevery pushed a commit that referenced this pull request Oct 1, 2016
@kasiditi @mhevery
fix: run all timers in passage of time in a single fakeAsync's tick call
a85db4c 
Closes #454
@kasiditi kasiditi mentioned this pull request Oct 9, 2016
Closed
@kasiditi kasiditi deleted the fix-tick branch October 30, 2016 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasiditi @googlebot @mhevery @jeffbcross