This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: make fetch promise patching safe#451
Closed
marclaval wants to merge 9 commits intoangular:masterfrom
Closed
Conversation
Contributor
|
Please add a test |
This means that we will stop polluting the global namespace when zone.js is included. Fixes angular#456
marclaval
force-pushed
the
fixFetchPatching
branch
4 times, most recently
from
3a26f7b to
8ff036f
Compare
Contributor
Author
|
For the test, the only way I found to reproduce this issue is to load a With the polyfill and without this fix, Safari 10 errors with |
marclaval
force-pushed
the
fixFetchPatching
branch
from
8ff036f to
1beaf19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
fetchPromiseis aZoneAwarePromise, then patching it creates infinite loop of.then().