Fix spelling error of 'describe' in jasmine patch#412
Fix spelling error of 'describe' in jasmine patch#412abierbaum wants to merge 1 commit intoangular:masterfrom
Conversation
Looks like a spelling error was preventing the jasmine patch from patching "describe".
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
| // Monkey patch all of the jasmine DSL so that each function runs in appropriate zone. | ||
| const jasmineEnv = jasmine.getEnv(); | ||
| ['desribe', 'xdescribe', 'fdescribe'].forEach((methodName) => { | ||
| ['describe', 'xdescribe', 'fdescribe'].forEach((methodName) => { |
There was a problem hiding this comment.
Just noticed this while looking through some stack traces. No idea if it is needed but looks like a typo.
Looks like a spelling error was preventing the jasmine patch from patching "describe".