Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Fix spelling error of 'describe' in jasmine patch#412

Closed
abierbaum wants to merge 1 commit intoangular:masterfrom
abierbaum:patch-1
Closed

Fix spelling error of 'describe' in jasmine patch#412
abierbaum wants to merge 1 commit intoangular:masterfrom
abierbaum:patch-1

Conversation

@abierbaum
Copy link
Copy Markdown
Contributor

Looks like a spelling error was preventing the jasmine patch from patching "describe".

Looks like a spelling error was preventing the jasmine patch from patching "describe".
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@abierbaum
Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Comment thread lib/jasmine/jasmine.ts
// Monkey patch all of the jasmine DSL so that each function runs in appropriate zone.
const jasmineEnv = jasmine.getEnv();
['desribe', 'xdescribe', 'fdescribe'].forEach((methodName) => {
['describe', 'xdescribe', 'fdescribe'].forEach((methodName) => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this while looking through some stack traces. No idea if it is needed but looks like a typo.

@mhevery mhevery closed this in d38ccde Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants