This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix long-stack-trace zone will not render correctly when reject a pro…#403
Merged
mhevery merged 1 commit intoangular:masterfrom Aug 19, 2016
Merged
fix long-stack-trace zone will not render correctly when reject a pro…#403mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a problem when using long-stack-trace zone, if I reject a promise inside the zone, the long stack trace will not rendered instead the original stack will be returned.
Because when promise was reject, zone will keep it in an array called _uncaughtPromiseErrors, and when drainMicroTaskQueue was called, the _uncaughtPromiseErrors will be rethrow with the original zone, but the Zone.currentTask has been cleared, so onHandleError of long-stack-trace will not rendered the correct long stack trace.
because the _uncaughtPromiseError has a reference of current task, we can check the task in long-stack-trace.