This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(browser): make Object.defineProperty patch safer#392
Merged
mhevery merged 1 commit intoangular:masterfrom Aug 11, 2016
Merged
fix(browser): make Object.defineProperty patch safer#392mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391
The following code was failing in Chrome and Firefox (at least) when zone was loaded:
I locally patched zone.js and was able to successfully run all Angular 2's tests with this fix. It solves the issues that were found in Chrome mobile 30 (Android 4.4.2).