fix(setTimeout): allow clearTimeout to be called in setTimeout callback#301
fix(setTimeout): allow clearTimeout to be called in setTimeout callback#301frankwallis wants to merge 1 commit intoangular:masterfrom
Conversation
… in setTimeout callback
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I have signed the CLA |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
2 participants
This is a fix for #290 - "More tasks executed than were scheduled" error.
The change is to set task.cancelFn = null before invoking a task for non-periodic tasks. As it is no longer possible to cancel the task which is just about to be invoked, I think this should be ok. I also updated the setTimeout tests to create new zones to run the tests in, as initially the test was incorrectly passing due to the task counts not being 0 to begin with.