This repository was archived by the owner on Feb 26, 2024. It is now read-only.
chore: Convert code to TypeScript#219
Closed
mhevery wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
mhevery
force-pushed
the
typescript
branch
4 times, most recently
from
e070144 to
c40c910
Compare
Contributor
There was a problem hiding this comment.
I think we should apply the patches here
Contributor
|
I think the bundle generation should also be updated, right ? A few comments but the changes seem ok, good to see TS ! Before merging the PR, it would be good to test into an Ng2 app. |
mhevery
force-pushed
the
typescript
branch
12 times, most recently
from
b3a3863 to
d247505
Compare
mhevery
force-pushed
the
typescript
branch
5 times, most recently
from
241b2e4 to
cc6869a
Compare
mhevery
force-pushed
the
typescript
branch
3 times, most recently
from
d2dac41 to
d0fe87e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.