This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Integrate WTF into zone.js#210
Closed
mhevery wants to merge 6 commits intoangular:masterfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
-1 you should add it to your own global gitignore
Contributor
There was a problem hiding this comment.
nah.. this line is to protect us from Misko not to protect Misko from our commits.
I'm fine with keeping it in.
6da186b to
9b91fd7
Compare
Contributor
Author
|
I have updated all with your comments. It fails on IE9, but I don't know how to get it reproduced locally. Could anyone help. |
Contributor
Author
|
I found the reason why IE9 was failing. We are all green. |
f75bf06 to
21f4099
Compare
Contributor
There was a problem hiding this comment.
the caller should pass the info
The tests run slow, because afterEach was async but never called done(). because it was afterEach any errors are ignored and so it did not show up as failure. Instead the test ran very slow until jasmine timed out. This fix corrects the afterEach and decreases the timeout to 1,000 ms.
When you have in async test (test with `done` argument) jasmine will execute the next test synchronously in the done handle. This makes sense for most tests, but now with zones. With zones running next test synchronously means that the current zone does not get cleared. This results in a chain of nested zones, which makes it hard to reason about it. We override the `clearStack` method which forces jasmine to always drain the stack before next test gets executed.
This rewrites the (set/clear)Timeout/Interval/Immediate method to render information in WTF. It also makes the code more explicit, by removing the need for bind method and instead creating explicit callbacks. The resulting code is faster, and easier to read and reason about.
setTimeout/clearTimeout and requeustAnimationFrame/cancelAnimationFrame have same semantics, so now they share the same code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc: @IgorMinar @btford @vicb