This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Replace unicode characters with ASCII#207
Closed
mgiuffrida wants to merge 1 commit intoangular:masterfrom
mgiuffrida:ascii
Closed
Replace unicode characters with ASCII#207mgiuffrida wants to merge 1 commit intoangular:masterfrom mgiuffrida:ascii
mgiuffrida wants to merge 1 commit intoangular:masterfrom
mgiuffrida:ascii
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Author
|
googlebot: oops, [email protected] is my chromium identity. this is also me. |
Contributor
There was a problem hiding this comment.
Coulf you please revert this change, brick.js is a 3rd party lib.
As it is used in tests only, it should not affect you ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode characters in source code screw up some build systems, like Chromium.