This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(addEventListener): when called from the global scope#191
Merged
vicb merged 3 commits intoangular:masterfrom Oct 6, 2015
Merged
fix(addEventListener): when called from the global scope#191vicb merged 3 commits intoangular:masterfrom
vicb merged 3 commits intoangular:masterfrom
Conversation
Contributor
Author
|
Also see the discussion in #184 /cc @matthewjh |
vicb
force-pushed
the
1005-evl
branch
2 times, most recently
from
7f5079d to
24941bf
Compare
Contributor
Author
|
Status:
I'll try to solve those tomorrow. |
Contributor
There was a problem hiding this comment.
remove the reference to "self", it only confuses the reader
Contributor
|
otherwise lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #190
@IgorMinar / @btford could you please review.
I'll check within the context of Angular & report here
/ref angular/angular#4531