fix(utils): fixes event target patch in web workers#184
fix(utils): fixes event target patch in web workers#184matthewjh wants to merge 1 commit intoangular:masterfrom matthewjh:055-fix-webworkers
Conversation
|
Thanks for the fix ! |
|
Maybe. If we change the target to What do you think? |
|
When would |
|
In 'working' code? I have no idea. But if someone does, in development, the following: Then shouldn't the behaviour be the same (or as close as possible) whether zone is loaded or not? |
|
Not sure I get your point here, wouldn't you write |
|
You would, yes. But my point was, that if a developer when writing their app mistakenly writes: Then the code should error out (or nor as the case may be) whether zone is loaded or not. Basically, the behaviour should be consistent for zone and non-zone code, even if that behaviour is an error. In this case, one would presume that |
|
That makes sense. It seems like Travis testing Angular with this is happy (currently re-running a failed test but looks like a glitch). Once it's green, I'll merge the PR. Thanks ! |
|
landed as ad5c0c8 |
Calling
addEventListenerin a Web Worker was breaking.No tests, but we should probably run all the zone tests (if possible) inside a web worker as part of the test suite to ensure compatibility.