This repository was archived by the owner on Feb 26, 2024. It is now read-only.
add specs for FileReader#136
Closed
robwormald wants to merge 5 commits intoangular:masterfrom
robwormald:bug/FileReader
Closed
add specs for FileReader#136robwormald wants to merge 5 commits intoangular:masterfrom robwormald:bug/FileReader
robwormald wants to merge 5 commits intoangular:masterfrom
robwormald:bug/FileReader
Conversation
Contributor
Author
|
so the simple fix works for chrome and firefox, but borks on Safari and IE. I referenced the hilarity going on in the websocket patch, and had a crack at fixing that - the latest commit fixes the zone issue (and a bunch of formatting, sorry) but isn't quite right as it loses the constants and readyState seems to drop out as well. I started going around in circles, so perhaps somebody else could have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from angular/angular#2533
this adds two specs, one using addEventListener that works, the other using the reader.onloadend event that fails with
The zone [1] is not a direct child of the zone [4]- i cribbed this from the similar XHR spec, so apologies if my logic is wrong here.see also plunker demo http://plnkr.co/edit/glcsfUFJo8RlE1sn55Cr?p=preview
i'm gonna have a crack at fixing this next, but wanted to get this in in case its something stupid i'm missing.