Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat: add option to disable jasmine clock patch, also rename the flag of auto jump in FakeAsyncTest#1222

Merged
vikerman merged 1 commit intoangular:masterfrom
JiaLiPassion:clock-patch
Apr 9, 2019
Merged

feat: add option to disable jasmine clock patch, also rename the flag of auto jump in FakeAsyncTest#1222
vikerman merged 1 commit intoangular:masterfrom
JiaLiPassion:clock-patch

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

  1. add an option fakeAsyncDisablePatchingClock to be able to disable jasmine.clock patch.
  2. rename fakeAsyncPatchLock to fakeAsyncAutoFakeAsyncWhenClockPatched because the original name is confused.
  3. if fakeAsyncDisablePatchingClock is true, should also make fakeAsyncAutoFakeAsyncWhenClockPatched to be false.

@vikerman, please review, thanks!

@vikerman vikerman merged commit 10e1b0c into angular:master Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants