This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(node): fix #1164, don't patch uncaughtException to prevent endless loop.#1170
Merged
mhevery merged 1 commit intoangular:masterfrom Dec 12, 2018
Merged
Conversation
3030778 to
a333a5d
Compare
… endless loop update yarn
a333a5d to
aa0331b
Compare
mhevery
approved these changes
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1164.
in
nodejs 10, there is a logic indomain.js.here
listener !== domainUncaughtExceptionClearwill crashzone, becauselistenerwill bezoneTask.invokeinstead of the original listener.So this PR will just
bypassuncaughtException.also update the
travis CItonodejs 10, to makenodejs 10work, I updatedyarn.lockto updatenatives to 1.1.3, otherwisegulpwill not work. gulpjs/gulp#2162