Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat(custom-element): patch customElement v1 APIs#1133

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:custom-element
Sep 11, 2018
Merged

feat(custom-element): patch customElement v1 APIs#1133
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:custom-element

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Sep 9, 2018 •
edited
Loading

Patch the CustomElement V1 APIs.

connectedCallback
disconnectedCallback
adoptedCallback
attributeChangedCallback

Make them run in the zone when they were defined by customElements.define.

So the issue like angular/angular#24185 may be resolved by this one.

@robwormald, @mhevery, please review, thank you!

@JiaLiPassion JiaLiPassion mentioned this pull request Sep 9, 2018
Closed
1 task
@JiaLiPassion JiaLiPassion force-pushed the custom-element branch 2 times, most recently from 82dc02b to 3f9d6bf Compare September 9, 2018 17:39
@remackgeek
Copy link
Copy Markdown

remackgeek commented Sep 9, 2018

This is cool! Does it play nice with the document-register-element polyfill (specifically 1.8.1)?

@JiaLiPassion JiaLiPassion force-pushed the custom-element branch 2 times, most recently from 87f7894 to 321137d Compare September 10, 2018 00:36
@JiaLiPassion
Copy link
Copy Markdown
Collaborator Author

JiaLiPassion commented Sep 10, 2018

@remackgeek, I believe before this PR, zone.js already support legacy document.registerElement. So document-register-element polyfill will also be supported.

@mhevery mhevery merged commit 427705f into angular:master Sep 11, 2018
@remackgeek remackgeek mentioned this pull request Sep 12, 2018
Closed
@remackgeek remackgeek mentioned this pull request Sep 20, 2018
Closed
@remackgeek remackgeek mentioned this pull request Sep 28, 2018
Closed
@benoitjchevalier benoitjchevalier mentioned this pull request Oct 5, 2018
Merged
@krishna217
Copy link
Copy Markdown

krishna217 commented Oct 16, 2018 •
edited
Loading

Which version will this fix be available ?

@remackgeek remackgeek mentioned this pull request Nov 10, 2018
Closed
@JiaLiPassion JiaLiPassion mentioned this pull request Nov 16, 2018
Closed
@antch
Copy link
Copy Markdown

antch commented Jan 18, 2019

Just FYI for anyone following the thread, this fix is available as of 0.8.27.

@khelsisura
Copy link
Copy Markdown

khelsisura commented Jan 28, 2019

@antch where?

@antch
Copy link
Copy Markdown

antch commented Jan 28, 2019

@harveyelsisura I'm not really sure what you're asking, I'm just saying that this pull request made it into the 0.8.27 release.

https://github.com/angular/zone.js/blob/v0.8.27/dist/zone.js#L3151

@ippeiukai ippeiukai mentioned this pull request Apr 12, 2019
Closed
@remackgeek remackgeek mentioned this pull request Jun 14, 2019
Closed
@gkalpak gkalpak mentioned this pull request Jun 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JiaLiPassion @remackgeek @krishna217 @antch @khelsisura @mhevery @googlebot