Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName#1113

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-1110
Jan 8, 2019
Merged

fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName#1113
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-1110

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Jul 17, 2018

fix #1110.

In nodejs, EventEmitter should support Symbol as eventName.

const symbolA = Symbol('A');
emitter.addListener(symbolA, listener);
emitter.removeListener(symbolA, listener);

@JiaLiPassion JiaLiPassion changed the title fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName WIP(event): fix #1110, nodejs EventEmitter should support Symbol eventName Jul 17, 2018
@JiaLiPassion JiaLiPassion force-pushed the issue-1110 branch 2 times, most recently from 6f017d5 to 3fe873a Compare July 18, 2018 01:31
@JiaLiPassion JiaLiPassion changed the title WIP(event): fix #1110, nodejs EventEmitter should support Symbol eventName fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName Jul 18, 2018
@jreidgreer
Copy link
Copy Markdown

jreidgreer commented Aug 7, 2018

@JiaLiPassion do you happen to know when this will get merged? Thanks!

@jreidgreer
Copy link
Copy Markdown

jreidgreer commented Oct 26, 2018

@JiaLiPassion do you have an update on when this might be merged in?

@JiaLiPassion
Copy link
Copy Markdown
Collaborator Author

JiaLiPassion commented Oct 27, 2018

@jreidgreer, I am not sure, If you want to test, I can create a temp release branch for you.

@Mathyn
Copy link
Copy Markdown

Mathyn commented Nov 6, 2018

Any updates on this? When can we expect this to be released?

@JiaLiPassion JiaLiPassion mentioned this pull request Dec 13, 2018
Merged
@mhevery mhevery merged commit 96420d6 into angular:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

makeAddListener breaks when the Event Name is a Symbol

5 participants

@JiaLiPassion @jreidgreer @Mathyn @mhevery @googlebot