fix(test): add flag to patch jasmine.clock, move fakeAsync/async into original bundle#1067
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
JiaLiPassion
force-pushed
the
testing-compatible
branch
3 times, most recently
from
6d4bbf3 to
0347110
Compare
JiaLiPassion
force-pushed
the
testing-compatible
branch
from
0347110 to
d463b70
Compare
3 participants
to resolve
breaking changesissue of angular/angular#23108delete new
zone-fake-async.jsandzone-async-testing.js. just addfakeAsync/asynctestinto originalzone.js/dist/fake-async.jsandzone.js/dist/async-test.js.add a flag
__zone_symbol__fakeAsyncPatchLockto control whether to patchjasmine.clock()infakeAsync. By default it isfalse, so no breaking changes.update .travis to test both
patchClockandnon patchClock.@mhevery, please review, I will also update the angular side to remove the breaking changes, thank you!