This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(fakeAsync): fix #1056, fakeAsync timerId should not be zero#1057
Merged
mhevery merged 1 commit intoangular:masterfrom Mar 30, 2018
Merged
fix(fakeAsync): fix #1056, fakeAsync timerId should not be zero#1057mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
force-pushed
the
interval-id
branch
from
ceb8e20 to
0f725ab
Compare
mhevery
previously approved these changes
Mar 30, 2018
mhevery
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1056
FakeAsyncTestSpec scheduler should not return a
zerotimerId, it will breakrxjs6or some library which will depends on thetimerId.