fix(event): should pass boolean to addEventListener if not support passive#1053
fix(event): should pass boolean to addEventListener if not support passive#1053mhevery merged 2 commits intoangular:masterfrom
Conversation
JiaLiPassion
force-pushed
the
passive
branch
2 times, most recently
from
e860d5f to
7c813dc
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
3 participants
based on the https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener,
IEnot support passoptionsas the 3rd parameter.So if you call addEventListener like this in
IEuser want to pass options as
{once: true, capture: false, passive: false}but because the
optionswill not work in IE11, the finally result will become{capture: true}, which will be the wrong result.So if browser not support
passive, we should pass not passoptionsas object but asboolean.just like this.