Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat(testing): can display pending tasks info when test timeout in jasmine/mocha#1038

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:async-error
Mar 30, 2018
Merged

feat(testing): can display pending tasks info when test timeout in jasmine/mocha#1038
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:async-error

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Mar 1, 2018

when jasmine/mocha test case timeout, the message will be

Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

It will a little difficult to know which one not finished.

in this PR, I record the async task information in ProxyZone, so when timeout, the error message will look like.

Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
--Pendng async tasks are: [type: macroTask, source: setTimeout, args: {handleId:3,isPeriodic:false,delay:10000,args:[]}

@mhevery mhevery merged commit 57bc80c into angular:master Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants