Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(event): fix #1021, removeListener/removeAllListeners should return eventEmitter#1022

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:nodejs-event
Mar 14, 2018
Merged

fix(event): fix #1021, removeListener/removeAllListeners should return eventEmitter#1022
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:nodejs-event

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

fix #1021.

EventEmitter.prototype.removeListener and EventEmitter.prototype.removeAllListeners should return EventEmitter itself to allow chaining.

@mhevery mhevery merged commit ab72df6 into angular:master Mar 14, 2018
@JiaLiPassion JiaLiPassion deleted the nodejs-event branch March 15, 2018 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patched removeAllListeners() doesn't seem to return the EventEmitter instance

3 participants