Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat(rollup): use new rollup config to prevent warning#1006

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:rollup
Feb 12, 2018
Merged

feat(rollup): use new rollup config to prevent warning#1006
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:rollup

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

  • new version of rollup have deprecate entry key, use input instead
  • add external key to specify rxjs library as external libs.
  • format gulpfile.js

mhevery
mhevery previously approved these changes Feb 10, 2018
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Feb 10, 2018

can you resolve conflicts?

@JiaLiPassion
Copy link
Copy Markdown
Collaborator Author

@mhevery , I have rebased, please review. thank you.

@mhevery mhevery merged commit 6b6b38a into angular:master Feb 12, 2018
@JiaLiPassion JiaLiPassion deleted the rollup branch March 15, 2018 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants