Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Include es6-promise into dependencies for CommonJS use case #166

@shuhei

Description

@shuhei

Hi, I'm using angular2 with browserify and noticed that I had to require('zone.js/lib/browser/zone-microtask') instead of require('zone.js') after a few hours of struggle. But it throws the following error unless I don't npm install -S es6-promise at the top level of my app.

Error: Cannot find module 'es6-promise' from '/path/to/my/app/node_modules/zone.js/lib/browser'

What do you think about putting es6-promise in dependencies instead of devDependencies? It is required by zone-microtask, which could be considered as a part of the library body, even though it's not in package.json#main.

Cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions