fix: Canceling already run task should not double decrement task counter

mhevery · mhevery · commit faa34851029e · 2016-03-23T12:11:28.000-07:00
Closes #290
diff --git a/lib/browser/browser.ts b/lib/browser/browser.ts
@@ -86,7 +86,10 @@ function patchTimer(
   var clearNative = patchMethod(window, cancelName, (delegate: Function) => function(self: any, args: any[]) {
     var task: Task = args[0];
     if (task && typeof task.type == 'string') {
-      task.zone.cancelTask(task);
+      if (task.cancelFn) {
+        // Do not cancel already canceled functions
+        task.zone.cancelTask(task);
+      }
     } else {
       // cause an error by calling it directly.
       delegate.apply(window, args);
diff --git a/lib/zone.ts b/lib/zone.ts
@@ -581,11 +581,11 @@ var Zone: ZoneType = (function(global) {
           }
         }
       } finally {
+        if (task.type == 'macroTask' && task.data && !task.data.isPeriodic) {
+          task.cancelFn = null;
+        }
         _currentZone = oldZone;
         _currentTask = previousTask;
-        if (task.type == 'microTask') {
-
-        }
       }
     }
 
@@ -761,7 +761,6 @@ var Zone: ZoneType = (function(global) {
       var prev = counts[type];
       var next = counts[type] = prev + count;
       if (next < 0) {
-        debugger;
         throw new Error('More tasks executed then were scheduled.');
       }
       if (prev == 0 || next == 0) {
diff --git a/test/browser/setTimeout.spec.ts b/test/browser/setTimeout.spec.ts
@@ -40,6 +40,18 @@ describe('setTimeout', function () {
     });
   });
 
+  it('should allow double cancelation of fns registered with setTimeout', function (done) {
+    var spy = jasmine.createSpy('spy');
+    var cancelId = setTimeout(spy, 0);
+    setTimeout(function () {
+      expect(spy).toHaveBeenCalled();
+      setTimeout(function () {
+        clearTimeout(cancelId);
+        done();
+      });
+    });
+  });
+
   it('should pass invalid values through', function () {
     clearTimeout(null);
     clearTimeout(<any>{});

Original file line number	Diff line number	Diff line change
`@@ -581,11 +581,11 @@ var Zone: ZoneType = (function(global) {`
`581`	`581`	`}`
`582`	`582`	`}`
`583`	`583`	`} finally {`
	`584`	`+ if (task.type == 'macroTask' && task.data && !task.data.isPeriodic) {`
	`585`	`+ task.cancelFn = null;`
	`586`	`+ }`
`584`	`587`	`_currentZone = oldZone;`
`585`	`588`	`_currentTask = previousTask;`
`586`		`- if (task.type == 'microTask') {`
`587`		`-`
`588`		`- }`
`589`	`589`	`}`
`590`	`590`	`}`
`591`	`591`
`@@ -761,7 +761,6 @@ var Zone: ZoneType = (function(global) {`
`761`	`761`	`var prev = counts[type];`
`762`	`762`	`var next = counts[type] = prev + count;`
`763`	`763`	`if (next < 0) {`
`764`		`- debugger;`
`765`	`764`	`throw new Error('More tasks executed then were scheduled.');`
`766`	`765`	`}`
`767`	`766`	`if (prev == 0 \|\| next == 0) {`