fix(task): fix #638, eventTask/Periodical task should not be reset after cancel in running state (#642)

JiaLiPassion · mhevery · commit eb9250da94b2 · 2017-03-06T16:14:55.000-08:00
diff --git a/lib/zone.ts b/lib/zone.ts
@@ -754,7 +754,11 @@ const Zone: ZoneType = (function(global: any) {
         }
       } finally {
         if (task.type == eventTask || (task.data && task.data.isPeriodic)) {
-          reEntryGuard && (task as ZoneTask)._transitionTo(scheduled, running, notScheduled);
+          // if the task's state is notScheduled, then it has already been cancelled
+          // we should not reset the state to scheduled
+          if (task.state !== notScheduled) {
+            reEntryGuard && (task as ZoneTask)._transitionTo(scheduled, running);
+          }
         } else {
           task.runCount = 0;
           this._updateTaskCount(task as ZoneTask, -1);
diff --git a/test/common/zone.spec.ts b/test/common/zone.spec.ts
@@ -299,6 +299,30 @@ describe('Zone', function() {
       ]);
     });
 
+    it('period task should not transit to scheduled state after being cancelled in running state',
+       () => {
+         const zone = Zone.current.fork({name: 'testZone'});
+
+         const task = zone.scheduleMacroTask('testPeriodTask', () => {
+           zone.cancelTask(task);
+         }, {isPeriodic: true}, () => {}, () => {});
+
+         task.invoke();
+         expect(task.state).toBe('notScheduled');
+       });
+
+    it('event task should not transit to scheduled state after being cancelled in running state',
+       () => {
+         const zone = Zone.current.fork({name: 'testZone'});
+
+         const task = zone.scheduleEventTask('testEventTask', () => {
+           zone.cancelTask(task);
+         }, null, () => {}, () => {});
+
+         task.invoke();
+         expect(task.state).toBe('notScheduled');
+       });
+
     describe('assert ZoneAwarePromise', () => {
       it('should not throw when all is OK', () => {
         Zone.assertZonePatched();
