fix(websockets): patch websockets via descriptors

IgorMinar · btford · commit d725f46a5040 · 2015-05-01T10:35:50.000-07:00
previously when we detected that patching via descriptors is possible we would patch everything, but websockets. This change adds descriptor patching for websockets. I also fixed existing unit test which was incorrectly written. The test now correctly fails without the patch. Closes #81
diff --git a/test/patch/WebSocket.spec.js b/test/patch/WebSocket.spec.js
@@ -18,9 +18,9 @@ describe('WebSocket', function () {
   it('should work with addEventListener', function (done) {
     var parent = window.zone;
 
-    socket.addEventListener('message', function (contents) {
+    socket.addEventListener('message', function (event) {
       expect(window.zone.parent).toBe(parent);
-      expect(contents.data).toBe('hi');
+      expect(event.data).toBe('hi');
       done();
     });
     socket.send('hi');
@@ -46,9 +46,8 @@ describe('WebSocket', function () {
     socket.send('hi');
   });
 
-  // TODO(vicb) this test is not working
-  // https://github.com/angular/zone.js/issues/81
-  xit('should work with onmessage', function (done) {
+
+  it('should work with onmessage', function (done) {
     var parent = window.zone;
     socket.onmessage = function (contents) {
       expect(window.zone.parent).toBe(parent);
diff --git a/zone.js b/zone.js
@@ -452,6 +452,7 @@ Zone.canPatchViaPropertyDescriptor = function () {
 Zone.patchViaPropertyDescriptor = function () {
   Zone.patchProperties(HTMLElement.prototype, Zone.onEventNames);
   Zone.patchProperties(XMLHttpRequest.prototype);
+  Zone.patchProperties(WebSocket.prototype);
 };
 
 // Whenever any event fires, we check the event target and all parents
