fix(patch): patchOnProperty getter should return original listener (#887)

JiaLiPassion · mhevery · commit d4e5ae8f6e72 · 2017-09-06T09:14:34.000-07:00
diff --git a/lib/common/utils.ts b/lib/common/utils.ts
@@ -170,8 +170,9 @@ export function patchProperty(obj: any, prop: string, prototype?: any) {
     if (!target) {
       return null;
     }
-    if (target[eventNameSymbol]) {
-      return wrapFn;
+    const listener = target[eventNameSymbol];
+    if (listener) {
+      return listener;
     } else if (originalDescGet) {
       // result will be null when use inline event attribute,
       // such as <button onclick="func();">OK</button>
diff --git a/test/browser/XMLHttpRequest.spec.ts b/test/browser/XMLHttpRequest.spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ifEnvSupports, supportPatchXHROnProperty} from '../test-util';
+import {ifEnvSupports, ifEnvSupportsWithDone, supportPatchXHROnProperty} from '../test-util';
 
 describe('XMLHttpRequest', function() {
   let testZone: Zone;
@@ -280,4 +280,27 @@ describe('XMLHttpRequest', function() {
       req.send();
     });
   });
+
+  it('should return origin listener when call xhr.onreadystatechange',
+     ifEnvSupportsWithDone(supportPatchXHROnProperty, function(done: Function) {
+       testZone.run(function() {
+         // sometimes this case will cause timeout
+         // so we set it longer
+         const req = new XMLHttpRequest();
+         req.open('get', '/', true);
+         const interval = (<any>jasmine).DEFAULT_TIMEOUT_INTERVAL;
+         (<any>jasmine).DEFAULT_TIMEOUT_INTERVAL = 5000;
+         const listener = req.onreadystatechange = function() {
+           if (req.readyState === 4) {
+             (<any>jasmine).DEFAULT_TIMEOUT_INTERVAL = interval;
+             done();
+           }
+         };
+         expect(req.onreadystatechange).toBe(listener);
+         req.onreadystatechange = function() {
+           return listener.apply(this, arguments);
+         };
+         req.send();
+       });
+     }));
 });
