fix: patch property descriptors in Object.create

btford · btford · commit 7b7258b9bf0b · 2014-06-06T11:16:09.000-07:00
Closes #24
diff --git a/zone.js b/zone.js
@@ -518,12 +518,14 @@ Zone.patchMutationObserverClass = function (className) {
 Zone.patchDefineProperty = function () {
   var _defineProperty = Object.defineProperty;
   var _getOwnPropertyDescriptor = Object.getOwnPropertyDescriptor;
+  var _create = Object.create;
 
   Object.defineProperty = function (obj, prop, desc) {
     if (isUnconfigurable(obj, prop)) {
       throw new TypeError('Cannot assign to read only property \'' + prop + '\' of ' + obj);
     }
-    return rewriteDescriptor(obj, prop, desc);
+    desc = rewriteDescriptor(obj, prop, desc);
+    return _defineProperty(obj, prop, desc);
   };
 
   Object.defineProperties = function (obj, props) {
@@ -533,6 +535,15 @@ Zone.patchDefineProperty = function () {
     return obj;
   };
 
+  Object.create = function (obj, proto) {
+    if (typeof proto === 'object') {
+      Object.keys(proto).forEach(function (prop) {
+        proto[prop] = rewriteDescriptor(obj, prop, proto[prop]);
+      });
+    }
+    return _create(obj, proto);
+  };
+
   Object.getOwnPropertyDescriptor = function (obj, prop) {
     var desc = _getOwnPropertyDescriptor(obj, prop);
     if (isUnconfigurable(obj, prop)) {
@@ -542,24 +553,23 @@ Zone.patchDefineProperty = function () {
   };
 
   Zone._redefineProperty = function (obj, prop, desc) {
-    return rewriteDescriptor(obj, prop, desc);
+    desc = rewriteDescriptor(obj, prop, desc);
+    return _defineProperty(obj, prop, desc);
   };
 
   function isUnconfigurable (obj, prop) {
     return obj && obj.__unconfigurables && obj.__unconfigurables[prop];
   }
 
   function rewriteDescriptor (obj, prop, desc) {
+    desc.configurable = true;
     if (!desc.configurable) {
-      desc.configurable = true;
       if (!obj.__unconfigurables) {
-        _defineProperty(obj, '__unconfigurables', {
-          value: {}
-        });
+        _defineProperty(obj, '__unconfigurables', { writable: true, value: {} });
       }
       obj.__unconfigurables[prop] = true;
     }
-    return _defineProperty(obj, prop, desc);
+    return desc;
   }
 };
 
