feat: add stackFramesFilter to longStackTraceZone

btford · btford · commit 7133de07872d · 2014-05-07T06:15:56.000-07:00
diff --git a/long-stack-trace-zone.js b/long-stack-trace-zone.js
@@ -8,13 +8,11 @@ Zone.Stacktrace = function (e) {
   this._e = e;
 };
 Zone.Stacktrace.prototype.get = function () {
-  var frames = this._e.stack.split('\n');
-
-  var markerIndex;
-  for (var markerIndex = frames.length - 1; markerIndex >= 0; markerIndex -= 1) {
-    if (frames[markerIndex].indexOf('marker@') === 0) {
-      return frames.slice(markerIndex+1).join('\n');
-    }
+  if (zone.stackFramesFilter) {
+    return this._e.stack.
+        split('\n').
+        filter(zone.stackFramesFilter).
+        join('\n');
   }
   return this._e.stack;
 }
@@ -46,8 +44,15 @@ Zone.getStacktrace = function () {
 
 Zone.longStackTraceZone = {
   getLongStacktrace: function (exception) {
-    var trace = [exception.stack];
+    var trace = [];
     var zone = this;
+    if (zone.stackFramesFilter) {
+      trace.push(exception.stack.split('\n').
+          filter(zone.stackFramesFilter).
+          join('\n'));
+    } else {
+      trace.push(exception.stack);
+    }
     var now = Date.now();
     while (zone && zone.constructedAtException) {
       trace.push(
@@ -59,6 +64,10 @@ Zone.longStackTraceZone = {
     return trace.join('\n');
   },
 
+  stackFramesFilter: function (line) {
+    return line.indexOf('zone.js') === -1;
+  },
+
   onError: function (exception) {
     var reporter = this.reporter || console.log.bind(console);
     reporter(exception.toString());
diff --git a/test/long-stack-trace-zone.spec.js b/test/long-stack-trace-zone.spec.js
@@ -28,4 +28,22 @@ describe('Zone.patch', function () {
     expect(log[0]).toBe('Error: hello');
     expect(log[1].split('--- ').length).toBe(4);
   });
+
+
+  it('should filter based on stackFramesFilter', function () {
+    lstz.fork({
+      stackFramesFilter: function (line) {
+        return line.indexOf('jasmine.js') === -1;
+      }
+    }).run(function () {
+      setTimeout(function () {
+        setTimeout(function () {
+          throw new Error('hello');
+        }, 0);
+      }, 0);
+    });
+
+    jasmine.Clock.tick(0);
+    expect(log[1]).not.toContain('jasmine.js');
+  });
 });
