fix(spec): FakeAsyncTestZoneSpec.flush() passes limit along to scheduler (#831)

nertzy · mhevery · commit 667cd6f0300b · 2017-07-12T13:58:00.000-07:00
Signed-off-by: Michael Stuart &lt;mistuart@corelogic.com&gt;
diff --git a/lib/zone-spec/fake-async-test.ts b/lib/zone-spec/fake-async-test.ts
@@ -249,10 +249,10 @@
       flushErrors();
     }
 
-    flush(): number {
+    flush(limit?: number): number {
       FakeAsyncTestZoneSpec.assertInZone();
       this.flushMicrotasks();
-      let elapsed = this._scheduler.flush();
+      let elapsed = this._scheduler.flush(limit);
       if (this._lastError !== null) {
         this._resetLastErrorAndThrow();
       }
diff --git a/test/zone-spec/fake-async-test.spec.ts b/test/zone-spec/fake-async-test.spec.ts
@@ -501,6 +501,26 @@ describe('FakeAsyncTestZoneSpec', () => {
           .toThrowError(
               'flush failed after reaching the limit of 20 tasks. Does your code use a polling timeout?');
     });
+
+    it('accepts a custom limit', function() {
+      expect(() => {
+        fakeAsyncTestZone.run(() => {
+          let z = 0;
+
+          let poll = () => {
+            setTimeout(() => {
+              z++;
+              poll();
+            }, 10);
+          };
+
+          poll();
+          testZoneSpec.flush(10);
+        });
+      })
+          .toThrowError(
+              'flush failed after reaching the limit of 10 tasks. Does your code use a polling timeout?');
+    });
   });
 
   describe('outside of FakeAsync Zone', () => {

Original file line number	Diff line number	Diff line change
`@@ -249,10 +249,10 @@`
`249`	`249`	`flushErrors();`
`250`	`250`	`}`
`251`	`251`
`252`		`- flush(): number {`
	`252`	`+ flush(limit?: number): number {`
`253`	`253`	`FakeAsyncTestZoneSpec.assertInZone();`
`254`	`254`	`this.flushMicrotasks();`
`255`		`- let elapsed = this._scheduler.flush();`
	`255`	`+ let elapsed = this._scheduler.flush(limit);`
`256`	`256`	`if (this._lastError !== null) {`
`257`	`257`	`this._resetLastErrorAndThrow();`
`258`	`258`	`}`