fix(WebSocket patch): fix WebSocket constants copy (#299)

mtsmfm · mhevery · commit 5dc4339ee34d · 2016-04-08T16:27:08.000-07:00
diff --git a/lib/browser/websocket.ts b/lib/browser/websocket.ts
@@ -30,5 +30,5 @@ export function apply(_global: any) {
 
     return proxySocket;
   };
-  (<any>global).WebSocket.prototype = Object.create(WS.prototype, {constructor:{value: WebSocket}});
+  for (var prop in WS) { _global.WebSocket[prop] = WS[prop]; }
 }
diff --git a/test/browser/WebSocket.spec.ts b/test/browser/WebSocket.spec.ts
@@ -118,5 +118,12 @@ if (!window['soucelabs']) {
         done();
       }, 100);
     }, TIMEOUT);
+
+    it('should have constants', function () {
+      expect(Object.keys(WebSocket)).toContain('CONNECTING');
+      expect(Object.keys(WebSocket)).toContain('OPEN');
+      expect(Object.keys(WebSocket)).toContain('CLOSING');
+      expect(Object.keys(WebSocket)).toContain('CLOSED');
+    });
   }));
 }

Original file line number	Diff line number	Diff line change
`@@ -30,5 +30,5 @@ export function apply(_global: any) {`
`30`	`30`
`31`	`31`	`return proxySocket;`
`32`	`32`	`};`
`33`		`- (<any>global).WebSocket.prototype = Object.create(WS.prototype, {constructor:{value: WebSocket}});`
	`33`	`+ for (var prop in WS) { _global.WebSocket[prop] = WS[prop]; }`
`34`	`34`	`}`