fix: closure related fixes (#1206)

vikerman · web-flow · commit 2a8415df975f · 2019-03-20T16:14:28.000-07:00
These fixes are needed to make Zone compile with closure with advanced
optimizations.
diff --git a/lib/common/fetch.ts b/lib/common/fetch.ts
@@ -5,6 +5,10 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/**
+ * @fileoverview
+ * @suppress {missingRequire}
+ */
 
 Zone.__load_patch('fetch', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
   interface FetchTaskData extends TaskData {
diff --git a/lib/zone-spec/long-stack-trace.ts b/lib/zone-spec/long-stack-trace.ts
@@ -113,7 +113,10 @@ function renderLongStackTrace(frames: LongStackTrace[], stack?: string): string
         // Fix issue https://github.com/angular/zone.js/issues/1195,
         // For event task of browser, by default, all task will share a
         // singleton instance of data object, we should create a new one here
-        task.data = {...task.data};
+
+        // The cast to `any` is required to workaround a closure bug which wrongly applies
+        // URL sanitization rules to .data access.
+        (task.data as any) = {...(task.data as any)};
       }
       (task.data as any)[creationTrace] = trace;
     }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,10 @@ function renderLongStackTrace(frames: LongStackTrace[], stack?: string): string`
`113`	`113`	`// Fix issue https://github.com/angular/zone.js/issues/1195,`
`114`	`114`	`// For event task of browser, by default, all task will share a`
`115`	`115`	`// singleton instance of data object, we should create a new one here`
`116`		`- task.data = {...task.data};`
	`116`	`+`
	`117`	+ // The cast to `any` is required to workaround a closure bug which wrongly applies
	`118`	`+ // URL sanitization rules to .data access.`
	`119`	`+ (task.data as any) = {...(task.data as any)};`
`117`	`120`	`}`
`118`	`121`	`(task.data as any)[creationTrace] = trace;`
`119`	`122`	`}`