fix: provide a more usefull error when configuring properties

mhevery · mhevery · commit 1fe4df0a3b48 · 2016-09-02T12:09:15.000-07:00
diff --git a/lib/browser/browser.ts b/lib/browser/browser.ts
@@ -84,7 +84,7 @@ function patchXHR(window: any) {
   var openNative = patchMethod(window.XMLHttpRequest.prototype, 'open', () => function(self: any, args: any[]) {
     self[XHR_SYNC] = args[2] == false;
     return openNative.apply(self, args);
-  };
+  });
 
   var sendNative = patchMethod(window.XMLHttpRequest.prototype, 'send', () => function(self: any, args: any[]) {
     var zone = Zone.current;
diff --git a/lib/browser/define-property.ts b/lib/browser/define-property.ts
@@ -79,7 +79,13 @@ function _tryDefineProperty (obj, prop, desc, originalConfigurableFlag) {
       } else {
         desc.configurable = originalConfigurableFlag;
       }
-      return _defineProperty(obj, prop, desc);
+      try {
+        return _defineProperty(obj, prop, desc);
+      } catch (e) {
+        var descJson: string  = null;
+        try { descJson = JSON.stringify(desc); } catch (e) { descJson = descJson.toString(); }
+        console.log(`Attempting to configure '${prop}' with descriptor '${descJson}' on object '${obj}' and got error, giving up: ${e}`);
+      }
     } else {
       throw e;
     }
diff --git a/package.json b/package.json
@@ -37,6 +37,7 @@
     "es6-promise": "^3.0.2",
     "gulp": "^3.8.11",
     "gulp-rename": "^1.2.2",
+    "gulp-rollup": "^2.3.0",
     "gulp-tsc": "^1.1.4",
     "gulp-uglify": "^1.2.0",
     "gulp-util": "^3.0.7",
