This repository was archived by the owner on Nov 21, 2025. It is now read-only.
build: update angular/angular packages/language-service/build.sh placeholder #1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
added a commit
to aspect-forks/angular
that referenced
this pull request
Jan 9, 2023
…pt to work with vscode-ng-language-service's new Bazel build 2nd half of angular/vscode-ng-language-service#1846. `npm_traslate_lock` in vscode-ng-language-service now has a data attribute so sed should only add another item to the list instead of adding a duplicate data attribute.
…eholder New token is within data now.
gregmagolan
force-pushed
the
update_build_sh_placeholder
branch
from
c90bdda to
9fbb2f2
Compare
dylhunn
approved these changes
Jan 9, 2023
dylhunn
added
target: patch
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2023
…pt to work with vscode-ng-language-service's new Bazel build (#48663) 2nd half of angular/vscode-ng-language-service#1846. `npm_traslate_lock` in vscode-ng-language-service now has a data attribute so sed should only add another item to the list instead of adding a duplicate data attribute. PR Close #48663
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2023
…pt to work with vscode-ng-language-service's new Bazel build (#48663) 2nd half of angular/vscode-ng-language-service#1846. `npm_traslate_lock` in vscode-ng-language-service now has a data attribute so sed should only add another item to the list instead of adding a duplicate data attribute. PR Close #48663
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2023
…pt to work with vscode-ng-language-service's new Bazel build (#48663) 2nd half of angular/vscode-ng-language-service#1846. `npm_traslate_lock` in vscode-ng-language-service now has a data attribute so sed should only add another item to the list instead of adding a duplicate data attribute. PR Close #48663
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…pt to work with vscode-ng-language-service's new Bazel build (angular#48663) 2nd half of angular/vscode-ng-language-service#1846. `npm_traslate_lock` in vscode-ng-language-service now has a data attribute so sed should only add another item to the list instead of adding a duplicate data attribute. PR Close angular#48663
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New token is within
datanow.@dylhunn @atscott Adding a new token here so the old one still works until it is not needed anymore. Old one (
PLACE_HOLDER_FOR_packages/language-service/build.sh_IN_angular_REPO) can be removed anytime if it is not needed.