This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat: enable absolute URL handling by default for all engines#1860
Closed
CaerusKaru wants to merge 1 commit intomasterfrom
Closed
feat: enable absolute URL handling by default for all engines#1860CaerusKaru wants to merge 1 commit intomasterfrom
CaerusKaru wants to merge 1 commit intomasterfrom
Conversation
This functionality was added in Angular v10.1 as an opt-in for all users. Since ngExpressEngine and ngHapiEngine are meant to enable best practices out of the box, we enable this for users by default as well.
CaerusKaru
added
action: review
target: major
alan-agius4
added
target: minor
alan-agius4
reviewed
Oct 10, 2020
| useValue: { | ||
| document: doc, | ||
| url: opts.url | ||
| url: opts.url, |
Collaborator
There was a problem hiding this comment.
I think we might want to provide the option for users to turn this off.
If I recall correctly, that was one of the reason this option exists in platform-server in the first place.
Collaborator
|
@CaerusKaru, should we close this PR? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was added in Angular v10.1 as an opt-in for
all users. Since ngExpressEngine and ngHapiEngine are meant to
enable best practices out of the box, we enable this for users
by default as well.