Skip to content

fix the warning: Warning: Unexpected input(s) 'lock-bot-key'#82

Merged
josephperrott merged 1 commit intoangular:masterfrom
bruno222:patch-1
Jan 11, 2021
Merged

fix the warning: Warning: Unexpected input(s) 'lock-bot-key'#82
josephperrott merged 1 commit intoangular:masterfrom
bruno222:patch-1

Conversation

@bruno222
Copy link
Copy Markdown
Contributor

@bruno222 bruno222 commented Dec 28, 2020

Why:

To remove this warning from the Github Action:
Warning: Unexpected input(s) 'lock-bot-key', valid inputs are ['lock-bot-token', 'locks-per-execution']

(see it happening here)

But in the end, it is lock-bot-token or lock-bot-key?

It is lock-bot-key for sure as it shows here and here.

TODO after merging:

To update the commit hash here

@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Dec 28, 2020
@bruno222

This comment has been minimized.

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 28, 2020
bruno222 referenced this pull request Dec 28, 2020
* fix(lock-closed): update `policyUrl` in `bundle.js`

In #77, `policyUrl` was fixed in `src/main.ts`, but not in the built
file that is actually used when running the action (`lib/bundle.js`).
As a result, the change did not take effect.

This commit updates `policyUrl` to `lib/bundle.js` as well. This will
help address angular/angular#39358 (once [lock-closed.yml][1] is updated
in all affected repositories).

[1]: https://github.com/angular/angular/blob/cfac8e0764498713f63a2335b46823e8a9b285c5/.github/workflows/lock-closed.yml#L13

* fix(lock-closed): fix `main` field in `package.json`

Change the `main` field in `package.json` to point to the correct file,
i.e. `lib/bundle.js` instead of `lib/main.js`.

This doesn't have any practical effect, since [action.yml][1] specifies
the actual entry-point used for the action, but it avoids confusion.

[1]: https://github.com/angular/dev-infra/blob/414834b2b24dd2df37c6ed00808387ee6fd91b66/github-actions/lock-closed/action.yml#L13

* docs(lock-closed): update `inputs` in `action.yml` (github-token --> lock-bot-token)

In PR #40, the authentication used by the `lock-closed` action was
changed. As part of this change, the `github-token` input parameter was
replaced by `lock-bot-token`. However, `lock-closed/action.yml` was not
updated accordingly, resulting in the following warning ([example][1]):

> Unexpected input(s) 'lock-bot-key', valid inputs are
> ['github-token', 'locks-per-execution']

This commit gets rid of the warnings by updating `action.yml` to list
the correct inputs.

[1]: https://github.com/angular/angular/actions/runs/318094899
Copy link
Copy Markdown
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thx, @bruno222 👍

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jan 11, 2021

BTW, there are actually 4 places/repos we need to update after this is merged:

@josephperrott josephperrott merged commit 7679cff into angular:master Jan 11, 2021
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jan 11, 2021

@bruno222, would like to see the fix all the way through and submit PRs for the repos mentioned in #82 (comment)? 😁
(Happy to do it myself if you don't feel like it.)

@bruno222
Copy link
Copy Markdown
Contributor Author

Cool @gkalpak, thanks mate.

PRs here:

angular/angular#40397
angular/angular-cli#19765
angular/components#21547
angular/universal#1937

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants