fix the warning: Warning: Unexpected input(s) 'lock-bot-key'#82
Merged
josephperrott merged 1 commit intoangular:masterfrom Jan 11, 2021
bruno222:patch-1
Merged
fix the warning: Warning: Unexpected input(s) 'lock-bot-key'#82josephperrott merged 1 commit intoangular:masterfrom bruno222:patch-1
josephperrott merged 1 commit intoangular:masterfrom
bruno222:patch-1
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bruno222
referenced
this pull request
Dec 28, 2020
* fix(lock-closed): update `policyUrl` in `bundle.js` In #77, `policyUrl` was fixed in `src/main.ts`, but not in the built file that is actually used when running the action (`lib/bundle.js`). As a result, the change did not take effect. This commit updates `policyUrl` to `lib/bundle.js` as well. This will help address angular/angular#39358 (once [lock-closed.yml][1] is updated in all affected repositories). [1]: https://github.com/angular/angular/blob/cfac8e0764498713f63a2335b46823e8a9b285c5/.github/workflows/lock-closed.yml#L13 * fix(lock-closed): fix `main` field in `package.json` Change the `main` field in `package.json` to point to the correct file, i.e. `lib/bundle.js` instead of `lib/main.js`. This doesn't have any practical effect, since [action.yml][1] specifies the actual entry-point used for the action, but it avoids confusion. [1]: https://github.com/angular/dev-infra/blob/414834b2b24dd2df37c6ed00808387ee6fd91b66/github-actions/lock-closed/action.yml#L13 * docs(lock-closed): update `inputs` in `action.yml` (github-token --> lock-bot-token) In PR #40, the authentication used by the `lock-closed` action was changed. As part of this change, the `github-token` input parameter was replaced by `lock-bot-token`. However, `lock-closed/action.yml` was not updated accordingly, resulting in the following warning ([example][1]): > Unexpected input(s) 'lock-bot-key', valid inputs are > ['github-token', 'locks-per-execution'] This commit gets rid of the warnings by updating `action.yml` to list the correct inputs. [1]: https://github.com/angular/angular/actions/runs/318094899
gkalpak
approved these changes
Jan 11, 2021
Member
|
BTW, there are actually 4 places/repos we need to update after this is merged: |
Member
|
@bruno222, would like to see the fix all the way through and submit PRs for the repos mentioned in #82 (comment)? 😁 |
This was referenced Jan 11, 2021
Contributor
Author
|
Cool @gkalpak, thanks mate. PRs here: angular/angular#40397 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
To remove this warning from the Github Action:
Warning: Unexpected input(s) 'lock-bot-key', valid inputs are ['lock-bot-token', 'locks-per-execution'](see it happening here)
But in the end, it is lock-bot-token or lock-bot-key?
It is lock-bot-key for sure as it shows here and here.
TODO after merging:
To update the commit hash here