fix(lock-closed): fix broken policy URL#77
Merged
josephperrott merged 1 commit intoangular:masterfrom Aug 20, 2020
gkalpak:fix-lock-closed-policy-url
Merged
fix(lock-closed): fix broken policy URL#77josephperrott merged 1 commit intoangular:masterfrom gkalpak:fix-lock-closed-policy-url
josephperrott merged 1 commit intoangular:masterfrom
gkalpak:fix-lock-closed-policy-url
Conversation
Previously, the policy URL used in the automatic conversation locking comment used a shortened SHA (6 our of 40 chars). Such SHAs only work as long as there is no other SHA in the repo starting with the same chars. Since there are now two SHAs starting with the same 6 chars, the link is broken and resulrts in a 404 error. Example: angular/angular-cli#18058 (comment) This commit fixes the broken link by using the full SHA (40 chars).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the policy URL used in the automatic conversation locking comment used a shortened SHA (6 our of 40 chars). Such SHAs only work as long as there is no other SHA in the repo starting with the same chars. Since there are now two SHAs starting with the same 6 chars, the link is broken and resulrts in a 404 error. Example: angular/angular-cli#18058 (comment)
This commit fixes the broken link by using the full SHA (40 chars).