feat(cdk/stepper): emit event when the user interacts with a step#22400
feat(cdk/stepper): emit event when the user interacts with a step#22400mmalerba merged 1 commit intoangular:masterfrom
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
src/cdk/stepper/stepper.ts
Outdated
| interacted = false; | ||
|
|
||
| /** Emits when the user has attempted to move away from the step. */ | ||
| @Output('interacted') interactedStream: EventEmitter<CdkStep> = new EventEmitter<CdkStep>(); |
There was a problem hiding this comment.
I'm a little on the fence about the naming here. I think that interacted sounds more like an event name, but we already used it for the interacted property. I'm open to other naming suggestions.
There was a problem hiding this comment.
Would it make sense to call it touched or is this a slightly different idea?
There was a problem hiding this comment.
It sort of is like touched, but I was trying to avoid using the same terminology is forms to avoid confusion.
There was a problem hiding this comment.
interacted sounds fine to me, but I think we normally call our streams xChanges
cc @jelbourn in case he has any naming opinions
crisbeto
force-pushed
the
19918/stepper-interacted-event
branch
3 times, most recently
from
5588975 to
9710d3f
Compare
src/cdk/stepper/stepper.ts
Outdated
| interacted = false; | ||
|
|
||
| /** Emits when the user has attempted to move away from the step. */ | ||
| @Output('interacted') interactedStream: EventEmitter<CdkStep> = new EventEmitter<CdkStep>(); |
There was a problem hiding this comment.
interacted sounds fine to me, but I think we normally call our streams xChanges
cc @jelbourn in case he has any naming opinions
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
interacted isn't my favorite API, but I don't have anything better
Adds an `interacted` event that will emit when the user tries to move away from a step. Fixes angular#19918.
crisbeto
force-pushed
the
19918/stepper-interacted-event
branch
from
9710d3f to
3611b0f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Adds an
interactedevent that will emit when the user tries to move away from a step.Fixes #19918.