test(cdk/testing): port the protractor tests to the webdriver env#22375
Merged
mmalerba merged 6 commits intoangular:webdriver-harness-environmentfrom Mar 31, 2021
Merged
test(cdk/testing): port the protractor tests to the webdriver env#22375mmalerba merged 6 commits intoangular:webdriver-harness-environmentfrom
mmalerba merged 6 commits intoangular:webdriver-harness-environmentfrom
Conversation
google-cla
bot
added
the
cla: yes
mmalerba
added
the
target: feature
jelbourn
approved these changes
Mar 31, 2021
Contributor
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
Overall LGTM, but someone else should also do a review on this one
devversion
reviewed
Mar 31, 2021
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
Just saw this. LGTM. One nit for a follow-up.
| * more pending tasks). | ||
| * | ||
| * For the implementation, see: | ||
| * https://github.com/angular/angular/blob/master/packages/platform-browser/src/browser/testability.ts#L30-L49 |
Member
There was a problem hiding this comment.
Nit: Use a perma link in case the location changes.
mmalerba
added a commit
that referenced
this pull request
Apr 8, 2021
* feat(cdk/testing): create a webdriver harness environment (#22321) * test(cdk/testing): Get webdriver test suite running with dummy tests (#22344) Co-authored-by: Paul Gschwendtner <[email protected]> * test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367) * test(cdk/testing): port the protractor tests to the webdriver env (#22375) * test(cdk/testing): enable webdriver tests on CI (#22379) Co-authored-by: Paul Gschwendtner <[email protected]> * fixup! test(cdk/testing): enable webdriver tests on CI (#22379) Co-authored-by: Paul Gschwendtner <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've confirmed that the tests all pass when run manually, but I don't have them working on CI yet.
Thanks to @kyliau for creating the example that I based the wait for Angular logic off of: https://github.com/kyliau/angular-wait/blob/main/server/server.ts