Skip to content

feat(cdk/testing): create a webdriver harness environment#22321

Merged
mmalerba merged 5 commits intoangular:webdriver-harness-environmentfrom
mmalerba:webdriver
Mar 25, 2021
Merged

feat(cdk/testing): create a webdriver harness environment#22321
mmalerba merged 5 commits intoangular:webdriver-harness-environmentfrom
mmalerba:webdriver

Conversation

@mmalerba
Copy link
Copy Markdown
Contributor

No description provided.

@mmalerba mmalerba requested a review from a team March 23, 2021 23:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2021
Copy link
Copy Markdown
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the tests aren't being run anywhere. Would that come in a follow-up?

@mmalerba
Copy link
Copy Markdown
Contributor Author

yes, this is a new feature branch where I'll be working on getting the tests running and then passing

@mmalerba mmalerba added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 24, 2021
@mmalerba
Copy link
Copy Markdown
Contributor Author

Comments addressed, PTAL

Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 104cd8b into angular:webdriver-harness-environment Mar 25, 2021
@mmalerba mmalerba deleted the webdriver branch March 25, 2021 17:10
mmalerba added a commit that referenced this pull request Apr 8, 2021
* feat(cdk/testing): create a webdriver harness environment (#22321)

* test(cdk/testing): Get webdriver test suite running with dummy tests (#22344)

Co-authored-by: Paul Gschwendtner <[email protected]>

* test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367)

* test(cdk/testing): port the protractor tests to the webdriver env (#22375)

* test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>

* fixup! test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants