build: run commit message check after other lint checks#22208
Merged
mmalerba merged 1 commit intoangular:masterfrom Mar 15, 2021
Merged
build: run commit message check after other lint checks#22208mmalerba merged 1 commit intoangular:masterfrom
mmalerba merged 1 commit intoangular:masterfrom
Conversation
We recently had some lint failures slip into the main branch, because they had both commit message failures and other lint failures. The problem was that we sometimes ignore commit message failures since they can be fixed by the caretaker, but if the commit check fails, it prevents any other the other lint checks from running. These changes move the commit message check to be last in the `lint` job so that if it fails, we know that everything else is in a mergeable state.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Mar 15, 2021
We recently had some lint failures slip into the main branch, because they had both commit message failures and other lint failures. The problem was that we sometimes ignore commit message failures since they can be fixed by the caretaker, but if the commit check fails, it prevents any other the other lint checks from running. These changes move the commit message check to be last in the `lint` job so that if it fails, we know that everything else is in a mergeable state. (cherry picked from commit 58118ec)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had some lint failures slip into the main branch, because they had both commit message failures and other lint failures. The problem was that we sometimes ignore commit message failures since they can be fixed by the caretaker, but if the commit check fails, it prevents the other lint checks from running.
These changes move the commit message check to be last in the
lintjob so that if it fails, we know that everything else is in a mergeable state.