docs(dev-app): remove references to mdc-select placeholder#22135
Merged
mmalerba merged 1 commit intoangular:masterfrom Mar 10, 2021
Merged
docs(dev-app): remove references to mdc-select placeholder#22135mmalerba merged 1 commit intoangular:masterfrom
mmalerba merged 1 commit intoangular:masterfrom
Conversation
mmalerba
added
merge safe
target: patch
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Mar 6, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, but there's a lint failure.
This was leftover from the legacy form-field appearance, which no longer exists in MDC. Selects don't have a "placeholder" their equivalent would be a null option
mmalerba
added a commit
that referenced
this pull request
Mar 10, 2021
This was leftover from the legacy form-field appearance, which no longer exists in MDC. Selects don't have a "placeholder" their equivalent would be a null option (cherry picked from commit 2a158f7)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was leftover from the legacy form-field appearance, which no longer
exists in MDC. Selects don't have a "placeholder" their equivalent would
be a null option