feat(material/menu): allow updating menu position a la autocomplete#22046
Merged
andrewseguin merged 1 commit intoangular:masterfrom Mar 23, 2021
Merged
Conversation
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Mar 14, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
The changes look good, but the CI is failing because:
- The API golden needs to be updated by running
yarn approve-api menu. - The MDC test lint check is failing, because you have to add the same test to
src/material-experimental/menu/menu.spec.ts.
src/material/menu/menu-trigger.ts
Outdated
| */ | ||
| updatePosition(): void { | ||
| if (this._overlayRef) { | ||
| this._overlayRef.updatePosition(); |
Member
There was a problem hiding this comment.
nit: can be reduce to this._overlayRef?.updatePosition().
Contributor
Author
There was a problem hiding this comment.
👍 wasn't sure which was preferred here.
terencehonles
force-pushed
the
allow-updating-menu-position
branch
from
336e038 to
a03b5c5
Compare
Contributor
Author
|
Thanks, I was expecting I'd have time to update the PR earlier, but I'll probably tied up for a bit if that doesn't handle everything. |
terencehonles
force-pushed
the
allow-updating-menu-position
branch
from
a03b5c5 to
4dff505
Compare
terencehonles
force-pushed
the
allow-updating-menu-position
branch
from
4dff505 to
e95cac6
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On document changes the menu may not be located in the correct location anymore. This exposes the
OverlayRef'supdatePositionon the trigger so a user can call it without relying on the private variable_overlayRef.