Skip to content

feat(cdk/a11y): allow focus options to be passed in to focus trap#21769

Merged
annieyw merged 1 commit intoangular:masterfrom
crisbeto:21767/focus-trap-options
Feb 5, 2021
Merged

feat(cdk/a11y): allow focus options to be passed in to focus trap#21769
annieyw merged 1 commit intoangular:masterfrom
crisbeto:21767/focus-trap-options

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Feb 2, 2021

Allows for an optional FocusOptions object to be passed into the various focus trap methods.

Fixes #21767.

Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Feb 2, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 2, 2021
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2021
@annieyw annieyw merged commit d7db7c8 into angular:master Feb 5, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…gular#21769)

Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…gular#21769)

Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(FocusTrap): focus methods should accept focus options

3 participants