feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService#21736
Merged
annieyw merged 3 commits intoangular:masterfrom Feb 5, 2021
Merged
feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService#21736annieyw merged 3 commits intoangular:masterfrom
annieyw merged 3 commits intoangular:masterfrom
Conversation
google-cla
bot
added
the
cla: yes
mbehrlich
force-pushed
the
map-directions
branch
from
e881266 to
c4c2517
Compare
crisbeto
reviewed
Jan 29, 2021
src/google-maps/map-directions-renderer/map-directions-service.ts
Outdated
Show resolved
Hide resolved
jelbourn
reviewed
Jan 29, 2021
mbehrlich
added
area: google-maps
feature
Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map.
Update public api guard with new component and service. Make minor optimizations with MapDirectionsService.
Add comments explaining how secret API key is loaded by dev-server.
mbehrlich
force-pushed
the
map-directions
branch
from
3685264 to
7071884
Compare
crisbeto
approved these changes
Feb 2, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM. We can tackle the API key issue in a follow-up.
crisbeto
added
action: merge
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
…angular#21736) * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Update public api guard with new component and service. Make minor optimizations with MapDirectionsService. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add comments explaining how secret API key is loaded by dev-server.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
…angular#21736) * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add the MapDirectionsService which wraps google.maps.DirectionsService to calculate routes between two points and the MapDirectionsRenderer component which allows these routes to be displayed on the Google Map. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Update public api guard with new component and service. Make minor optimizations with MapDirectionsService. * feat(google-maps): Add MapDirectionsRenderer and MapDirectionsService Add comments explaining how secret API key is loaded by dev-server.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the MapDirectionsService which wraps google.maps.DirectionsService
to calculate routes between two points and the MapDirectionsRenderer
component which allows these routes to be displayed on the Google Map.